Re: [PATCH V2 4/5] RDMA/iser: support iWARP devices

Doug Ledford
2015-06-30T20:20:48Z

[-- Attachment #1: Type: text/plain, Size: 1673 bytes --]

On 06/30/2015 02:42 PM, Steve Wise wrote:
>
>
>> -----Original Message-----
>> From: Hefty, Sean [mailto:sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org]
>> Sent: Tuesday, June 30, 2015 12:04 PM
>> To: Jason Gunthorpe; Steve Wise
>> Cc: 'Sagi Grimberg'; dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; sagig@mellanox.com; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; infinipath;
>> eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org; ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
>> Subject: RE: [PATCH V2 4/5] RDMA/iser: support iWARP devices
>>
>>>> I prefer to decouple the iSER changes with this core work.
>>>> Jason/Sean... thoughts? I could do the iSER w/o patch 3, and the
>>>> follow up with a series that includes our final solution on
>>>> transport independent memory registration and change all the TI
>>>> kernel users (iser and nfsrdma) along with it.
>>>
>>> There has a been a big push lately to drop the strange transport
>>> specific stuff - if you are comitted to seeing the access flag clean
>>> up series through then I don't see a problem with using whatever order
>>> you like.
>>
>> I agree.
>
> Ok, then I'll do this:
>
> 1) series with iser changes to enable iwarp including mlx/ipath/qib patches to set max_sge_rd
> 2) series on transport independent access flags / memory reg - updating the kernel ULPs too.

I've quickly reviewed the series and you plan here seems fine. I'm
bouncing this out of my queue and will wait for the next version.

--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]