From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH V2 3/5] RDMA/core: transport-independent access flags Date: Thu, 2 Jul 2015 16:23:22 +0300 Message-ID: <55953B4A.1070509@dev.mellanox.co.il> References: <20150629213332.4188.87551.stgit@build.ogc.int> <20150629213618.4188.50574.stgit@build.ogc.int> <55925FAE.4090004@dev.mellanox.co.il> <1828884A29C6694DAF28B7E6B8A82373A8FFB053@ORSMSX109.amr.corp.intel.com> <5594D8BC.8000300@dev.mellanox.co.il> <559539E0.9030808@opengridcomputing.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <559539E0.9030808-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steve Wise , "Hefty, Sean" , "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Cc: "roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org" , infinipath , "eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" , "ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 7/2/2015 4:17 PM, Steve Wise wrote: > On 7/2/2015 1:22 AM, Sagi Grimberg wrote: >> On 6/30/2015 8:10 PM, Hefty, Sean wrote: >>>> I suggest to start consolidating to ib_create_mr() that receives an >>>> extensible ib_mr_init_attr and additional attributes can be mr_roles >>>> and mr_attrs. >>> >>> I think this makes sense, but does it really help? >>> If the end result is that the app and providers basically >>> end up switching on mr_attr::type, we end up reducing the >>> number of APIs, but the code complexity remains the same. >>> >> >> I think it will reduce code complexity. First, the callers >> will have a single API to allocate a memory key. I'm not sure why you >> say that app needs to switch on mr::type, it knows which type it wants. >> > > I dont see how doing this is less complex: > > attr = FASTREG > mr = create_mr(attr) > > vs: > > mr = lloc_fast_reg_mr() The simplification is that you can facilitate changes like your mr_roles and any other things we may want to add to mr allocation easily instead of suggesting wrappers over wrappers over wrappers. This is why I suggested it in the first place. Sagi. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html