From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH V4 3/5] RDMA/iser: Limit sg tablesize and max_sectors to device fastreg max depth Date: Sun, 05 Jul 2015 08:15:05 -0500 Message-ID: <55992DD9.2010909@opengridcomputing.com> References: <20150702151508.12946.29133.stgit@build.ogc.int> <20150702151619.12946.79500.stgit@build.ogc.int> <5598FFA3.5020508@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5598FFA3.5020508-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: roid-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 7/5/2015 4:57 AM, Sagi Grimberg wrote: > On 7/2/2015 6:16 PM, Steve Wise wrote: >> Currently the sg tablesize, which dictates fast register page list >> depth to use, does not take into account the limits of the rdma device. >> So adjust it once we discover the device fastreg max depth limit. Also >> adjust the max_sectors based on the resulting sg tablesize. >> >> Signed-off-by: Steve Wise >> Reviewed-by: Sagi Grimberg >> --- >> drivers/infiniband/ulp/iser/iscsi_iser.c | 9 +++++++++ >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c >> b/drivers/infiniband/ulp/iser/iscsi_iser.c >> index 6a594aa..0ed8638 100644 >> --- a/drivers/infiniband/ulp/iser/iscsi_iser.c >> +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c >> @@ -640,6 +640,15 @@ iscsi_iser_session_create(struct iscsi_endpoint >> *ep, >> SHOST_DIX_GUARD_CRC); >> } >> >> + /* >> + * Limit the sg_tablesize and max_sectors based on the device >> + * max fastreg page list length. >> + */ >> + shost->sg_tablesize = min_t(u32, shost->sg_tablesize, >> + ib_conn->device->dev_attr.max_fast_reg_page_list_len); >> + shost->max_sectors = >> + min(1024, (shost->sg_tablesize * PAGE_SIZE) >> 9); >> + > > Steve, > > This triggers a compilation warning: > drivers/infiniband/ulp/iser/iscsi_iser.c: In function > iscsi_iser_session_create: > drivers/infiniband/ulp/iser/iscsi_iser.c:653: warning: comparison of > distinct pointer types lacks a cast > > For next time, let's remove the reviewed-by tags and I'll re-review the > patches. Oops. My bad. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html