Re: [PATCH for-4.2] IB/mlx4: Fix and optimize SRIOV slave init

Doug Ledford
2015-07-09T14:27:47Z

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

On 07/09/2015 10:02 AM, Or Gerlitz wrote:
> On 7/9/2015 3:31 PM, Doug Ledford wrote:
>>> i Doug,
>>> >
>>> >I'd like Jack to review this before we ack, not sure if he's in today,
>>> >so he might get to look on that only on Sunday.
>> Try to get it reviewed before then please. If it passes my
>> build/functional tests (which I want to get to today), it will go in a
>> pull request tomorrow.
>
> I hope Jack will be able to look on that -- I took a look -- seems fine.
> However, please (please) break it to two patches: one that fixes the
> leak and one that does the small optimization. Recently I came into a
> conclusion that each time we are violating the kernel practice of
> makingsure a patch has **one** logical change, we either add a bug or
> fix a bug in an unnoticed way, so...again, pull based on what tree/branch?

It's split. The tree will be out (probably) later today.

--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]