From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Maninder Singh <maninder1.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH for-4.2] IB/mlx4: Fix and optimize SRIOV slave init
Date: Thu, 9 Jul 2015 17:02:34 +0300 [thread overview]
Message-ID: <559E7EFA.3070805@mellanox.com> (raw)
In-Reply-To: <559E69AD.9050406-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 7/9/2015 3:31 PM, Doug Ledford wrote:
>> i Doug,
>> >
>> >I'd like Jack to review this before we ack, not sure if he's in today,
>> >so he might get to look on that only on Sunday.
> Try to get it reviewed before then please. If it passes my
> build/functional tests (which I want to get to today), it will go in a
> pull request tomorrow.
I hope Jack will be able to look on that -- I took a look -- seems fine.
However, please (please) break it to two patches: one that fixes the
leak and one that does the small optimization. Recently I came into a
conclusion that each time we are violating the kernel practice of
makingsure a patch has **one** logical change, we either add a bug or
fix a bug in an unnoticed way, so...again, pull based on what tree/branch?
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-09 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 22:30 [PATCH for-4.2] IB/mlx4: Fix and optimize SRIOV slave init Doug Ledford
[not found] ` <23f3dca9ff4b71155bd898be1f3cbd8eeb9df27f.1436394658.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-09 8:28 ` Or Gerlitz
[not found] ` <559E30C3.5050702-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-09 12:31 ` Doug Ledford
[not found] ` <559E69AD.9050406-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-09 14:02 ` Or Gerlitz [this message]
[not found] ` <559E7EFA.3070805-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-09 14:27 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E7EFA.3070805@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maninder1.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox