From: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: "Jérôme Glisse" <jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Christophe Harle <charle-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Duncan Poole <dpoole-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Sherry Cheung <SCheung-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Subhash Gutti <sgutti-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
John Hubbard <jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Mark Hairgrove
<mhairgrove-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Lucien Dunning <ldunning-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Cameron Buschardt
<cabuschardt-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Arvind Gopalakrishnan
<arvindg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Shachar Raindel <raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Liran Liss <liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 4/8] IB/odp/hmm: add new kernel option to use HMM for ODP.
Date: Tue, 21 Jul 2015 13:37:57 +0300 [thread overview]
Message-ID: <55AE2105.6090107@mellanox.com> (raw)
In-Reply-To: <1437159665-6612-5-git-send-email-jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 17/07/2015 22:01, Jérôme Glisse wrote:
> This is a preparatory patch for HMM implementation of ODP (on demand
> paging). It introduce a new configure option and add proper build
> time conditional code section. Enabling INFINIBAND_ON_DEMAND_PAGING_HMM
> will result in build error with this patch.
>
> Signed-off-by: Jérôme Glisse <jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
...
> diff --git a/include/rdma/ib_umem_odp.h b/include/rdma/ib_umem_odp.h
> index 3da0b16..765aeb3 100644
> @@ -100,28 +124,13 @@ void ib_umem_odp_release(struct ib_umem *umem);
>
> #define ODP_DMA_ADDR_MASK (~(ODP_READ_ALLOWED_BIT | ODP_WRITE_ALLOWED_BIT))
>
> +
Please avoid adding double blank lines. You can find more of these by
running checkpatch on the patch.
Other than that:
Reviewed-by: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-21 10:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 19:00 [PATCH 0/8] Add ODP support using HMM Jérôme Glisse
2015-07-17 19:00 ` [PATCH 1/8] IB/mlx5: add a new parameter to __mlx_ib_populated_pas for ODP with HMM Jérôme Glisse
2015-07-17 19:00 ` [PATCH 2/8] IB/mlx5: add a new parameter to mlx5_ib_update_mtt() " Jérôme Glisse
2015-07-17 19:01 ` [PATCH 3/8] IB/odp: export rbt_ib_umem_for_each_in_range() Jérôme Glisse
[not found] ` <1437159665-6612-4-git-send-email-jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-21 8:30 ` Haggai Eran
2015-07-17 19:01 ` [PATCH 4/8] IB/odp/hmm: add new kernel option to use HMM for ODP Jérôme Glisse
[not found] ` <1437159665-6612-5-git-send-email-jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-21 10:37 ` Haggai Eran [this message]
2015-07-17 19:01 ` [PATCH 5/8] IB/odp/hmm: add core infiniband structure and helper for ODP with HMM v2 Jérôme Glisse
2015-07-17 19:01 ` [PATCH 6/8] IB/mlx5/hmm: add mlx5 HMM device initialization and callback v3 Jérôme Glisse
[not found] ` <1437159665-6612-7-git-send-email-jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-21 10:44 ` Haggai Eran
2015-07-21 10:51 ` Haggai Eran
[not found] ` <55AE2431.20105-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-21 15:14 ` Jerome Glisse
[not found] ` <1450090324.1616771.1437491699456.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-21 16:06 ` Jason Gunthorpe
2015-07-17 19:01 ` [PATCH 7/8] IB/mlx5/hmm: add page fault support for ODP on HMM v2 Jérôme Glisse
2015-07-17 19:01 ` [PATCH 8/8] IB/mlx5/hmm: enable ODP using HMM Jérôme Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE2105.6090107@mellanox.com \
--to=haggaie-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=SCheung-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=arvindg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=cabuschardt-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=charle-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=dpoole-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=ldunning-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=mhairgrove-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sgutti-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox