From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCH 4/8] IB/odp/hmm: add new kernel option to use HMM for ODP. Date: Tue, 21 Jul 2015 13:37:57 +0300 Message-ID: <55AE2105.6090107@mellanox.com> References: <1437159665-6612-1-git-send-email-jglisse@redhat.com> <1437159665-6612-5-git-send-email-jglisse@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1437159665-6612-5-git-send-email-jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Christophe Harle , Duncan Poole , Sherry Cheung , Subhash Gutti , John Hubbard , Mark Hairgrove , Lucien Dunning , Cameron Buschardt , Arvind Gopalakrishnan , Shachar Raindel , Liran Liss List-Id: linux-rdma@vger.kernel.org On 17/07/2015 22:01, J=C3=A9r=C3=B4me Glisse wrote: > This is a preparatory patch for HMM implementation of ODP (on demand > paging). It introduce a new configure option and add proper build > time conditional code section. Enabling INFINIBAND_ON_DEMAND_PAGING_H= MM > will result in build error with this patch. >=20 > Signed-off-by: J=C3=A9r=C3=B4me Glisse > --- =2E.. > diff --git a/include/rdma/ib_umem_odp.h b/include/rdma/ib_umem_odp.h > index 3da0b16..765aeb3 100644 > @@ -100,28 +124,13 @@ void ib_umem_odp_release(struct ib_umem *umem); > =20 > #define ODP_DMA_ADDR_MASK (~(ODP_READ_ALLOWED_BIT | ODP_WRITE_ALLOWE= D_BIT)) > =20 > + Please avoid adding double blank lines. You can find more of these by running checkpatch on the patch. Other than that: Reviewed-by: Haggai Eran -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html