From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org
Cc: Amir Vadai <amirv@mellanox.com>,
Andy Grover <andy.grover@oracle.com>,
Chien Yen <chien.yen@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Dominique Martinet <dominique.martinet@cea.fr>,
Eli Cohen <eli@mellanox.com>,
Eric Van Hensbergen <ericvh@gmail.com>,
Ido Shamay <idos@mellanox.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Or Gerlitz <ogerlitz@mellanox.com>, Roi Dayan <roid@mellanox.com>,
Ron Minnich <rminnich@sandia.gov>,
Sagi Grimberg <sagig@mellanox.com>,
Simon Derr <simon.derr@bull.net>,
Tom Tucker <tom@opengridcomputing.com>,
Zach Brown <zach.brown@oracle.com>,
rds-devel@oss.oracle.com, target-devel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH 00/10] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey
Date: Thu, 23 Jul 2015 06:47:26 -0700 [thread overview]
Message-ID: <55B0F06E.8000603@sandisk.com> (raw)
In-Reply-To: <1437608083-22898-1-git-send-email-jgunthorpe@obsidianresearch.com>
On 07/22/15 16:34, Jason Gunthorpe wrote:
> The remaining users of ib_get_dma_mr are all unsafe:
> [ ... ]
> drivers/infiniband/ulp/srp/ib_srp.c:
> srp_dev->mr = ib_get_dma_mr(srp_dev->pd,
> IB_ACCESS_LOCAL_WRITE |
> IB_ACCESS_REMOTE_READ |
> IB_ACCESS_REMOTE_WRITE);
Hello Jason,
This statement might need some clarification. Are you aware that this
memory region is only used if the kernel module parameter
register_always is zero ?
I will try to find some time to test the SRP changes in this series but
I'm not sure yet when I will be able to do that.
Bart.
next prev parent reply other threads:[~2015-07-23 13:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 23:34 [PATCH 00/10] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey Jason Gunthorpe
2015-07-22 23:34 ` [PATCH 01/10] IB/core: Guarantee that a local_dma_lkey is available Jason Gunthorpe
2015-07-23 10:47 ` Sagi Grimberg
2015-07-23 18:36 ` Jason Gunthorpe
2015-07-22 23:34 ` [PATCH 04/10] IB/mlx4: Remove ib_get_dma_mr calls Jason Gunthorpe
2015-07-22 23:34 ` [PATCH 05/10] IB/mlx5: " Jason Gunthorpe
2015-07-22 23:34 ` [PATCH 06/10] IB/iser: Use pd->local_dma_lkey Jason Gunthorpe
2015-07-23 10:49 ` Sagi Grimberg
[not found] ` <1437608083-22898-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-07-22 23:34 ` [PATCH 02/10] IB/mad: Remove ib_get_dma_mr calls Jason Gunthorpe
2015-07-22 23:34 ` [PATCH 03/10] IB/ipoib: " Jason Gunthorpe
2015-07-22 23:34 ` [PATCH 07/10] iser-target: " Jason Gunthorpe
2015-07-23 10:49 ` Sagi Grimberg
2015-07-22 23:34 ` [PATCH 08/10] IB/srp: Use pd->local_dma_lkey Jason Gunthorpe
[not found] ` <1437608083-22898-9-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-07-23 10:50 ` Sagi Grimberg
2015-07-22 23:34 ` [PATCH 09/10] ib_srpt: Remove ib_get_dma_mr calls Jason Gunthorpe
2015-07-23 10:51 ` Sagi Grimberg
2015-07-22 23:34 ` [PATCH 10/10] net/9p: " Jason Gunthorpe
2015-07-23 7:46 ` Dominique Martinet
2015-07-23 10:56 ` [PATCH 00/10] IB: Replace safe uses for ib_get_dma_mr with pd->local_dma_lkey Sagi Grimberg
2015-07-23 13:47 ` Bart Van Assche [this message]
2015-07-23 18:30 ` Jason Gunthorpe
[not found] ` <20150723183044.GA1868-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-07-23 18:42 ` Bart Van Assche
[not found] ` <55B13583.5010208-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-07-23 18:47 ` Jason Gunthorpe
2015-07-26 8:45 ` Sagi Grimberg
2015-07-29 16:39 ` Doug Ledford
2015-07-25 6:27 ` Christoph Hellwig
2015-07-28 15:01 ` J.L. Burr
2015-07-28 18:23 ` Jason Gunthorpe
2015-07-28 20:58 ` J.L. Burr
2015-07-28 22:10 ` Jason Gunthorpe
2015-07-28 23:56 ` J.L. Burr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0F06E.8000603@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=amirv@mellanox.com \
--cc=andy.grover@oracle.com \
--cc=chien.yen@oracle.com \
--cc=dledford@redhat.com \
--cc=dominique.martinet@cea.fr \
--cc=eli@mellanox.com \
--cc=ericvh@gmail.com \
--cc=hch@infradead.org \
--cc=idos@mellanox.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-rdma@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=ogerlitz@mellanox.com \
--cc=rds-devel@oss.oracle.com \
--cc=rminnich@sandia.gov \
--cc=roid@mellanox.com \
--cc=sagig@mellanox.com \
--cc=simon.derr@bull.net \
--cc=target-devel@vger.kernel.org \
--cc=tom@opengridcomputing.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox