Re: [PATCH v2 02/13] IB/core: Find the network device matching connection parameters

Haggai Eran
2015-07-28T08:16:08Z

On 27/07/2015 20:45, Jason Gunthorpe wrote:
> On Sun, Jul 26, 2015 at 06:33:41PM +0300, Haggai Eran wrote:
>> From: Yotam Kenneth <yotamke-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> In the case of IPoIB, and maybe in other cases, the network device is
>> managed by an upper-layer protocol (ULP). In order to expose this
>> network device to other users of the IB device, let ULPs implement
>> a callback that returns network device according to connection parameters.
>>
>> The IB device and port, together with the P_Key and the GID should
>> be enough to uniquely identify the ULP net device. However, in current
>> kernels there can be multiple IPoIB interfaces created with the same GID.
>> Furthermore, such configuration may be desireable to support ipvlan-like
>> configurations for RDMA CM with IPoIB. To resolve the device in these
>> cases the code will also take the IP address as an additional input.
>
> I already sent this, but again:
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

Thanks. I only removed it because the patch had some changes related to
the locking scheme, and I wasn't sure you would approve them.

Thanks anyway,
Haggai