From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH 11/22] IB/iser: Remove dead code in fmr_pool alloc/free Date: Thu, 30 Jul 2015 15:23:18 +0300 Message-ID: <55BA1736.2010204@dev.mellanox.co.il> References: <1438243595-32288-1-git-send-email-sagig@mellanox.com> <1438243595-32288-12-git-send-email-sagig@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz , Sagi Grimberg Cc: Doug Ledford , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 7/30/2015 1:31 PM, Or Gerlitz wrote: > On Thu, Jul 30, 2015 at 11:06 AM, Sagi Grimberg wrote: >> In the past the we always tried to allocate an fmr_pool >> and if it failed on ENOSYS (not supported) then we continued >> with dma mr. This is not the case anymore and if we tried to >> allocate an fmr_pool then it is supported and we expect to succeed. > > AFAIK, the ENOSYS flow was something that came into play when working > e.g over VF drivers such as mlx4 that don't support fmr-ing but we still wanted > an optimal performance. What does "this is not the case anymore" means? these > VF drivers are still out there. Today, iser is not usable with no FRWR and no FMR support. (it once was when we bounced to higher-order allocations but we don't do that anymore). Memory registration is a requirement support for iser today. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html