From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Bart Van Assche
<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] IB/core, cma: Make __attribute_const__ declarations sparse-friendly
Date: Tue, 4 Aug 2015 19:54:59 +0300 [thread overview]
Message-ID: <55C0EE63.3030504@dev.mellanox.co.il> (raw)
In-Reply-To: <55BF9E80.3030306-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
On 8/3/2015 8:01 PM, Bart Van Assche wrote:
> Move the __attribute_const__ declarations such that sparse understands
> that these apply to the function itself and not to the return type.
> This avoids that sparse reports error messages like the following:
>
> drivers/infiniband/core/verbs.c:73:12: error: symbol 'ib_event_msg' redeclared with different type (originally declared at include/rdma/ib_verbs.h:470) - different modifiers
>
> Fixes: 2b1b5b601230 ("IB/core, cma: Nice log-friendly string helpers")
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
> Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks Bart.
Reviewed-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-04 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 17:01 [PATCH] IB/core, cma: Make __attribute_const__ declarations sparse-friendly Bart Van Assche
[not found] ` <55BF9E80.3030306-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-08-04 16:54 ` Sagi Grimberg [this message]
2015-08-14 19:27 ` Doug Ledford
[not found] ` <55CE410C.7080002-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-29 21:16 ` Bart Van Assche
[not found] ` <56328C9A.1030105-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2015-10-30 22:00 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C0EE63.3030504@dev.mellanox.co.il \
--to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).