From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH] IB/core, cma: Make __attribute_const__ declarations sparse-friendly Date: Tue, 4 Aug 2015 19:54:59 +0300 Message-ID: <55C0EE63.3030504@dev.mellanox.co.il> References: <55BF9E80.3030306@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55BF9E80.3030306-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche , Doug Ledford Cc: Sagi Grimberg , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 8/3/2015 8:01 PM, Bart Van Assche wrote: > Move the __attribute_const__ declarations such that sparse understands > that these apply to the function itself and not to the return type. > This avoids that sparse reports error messages like the following: > > drivers/infiniband/core/verbs.c:73:12: error: symbol 'ib_event_msg' redeclared with different type (originally declared at include/rdma/ib_verbs.h:470) - different modifiers > > Fixes: 2b1b5b601230 ("IB/core, cma: Nice log-friendly string helpers") > Signed-off-by: Bart Van Assche > Cc: Sagi Grimberg Thanks Bart. Reviewed-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html