From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: IB/mlx5: Support IB_WR_REG_SIG_MR
Date: Wed, 12 Aug 2015 20:19:21 +0300 [thread overview]
Message-ID: <55CB8019.5010609@dev.mellanox.co.il> (raw)
In-Reply-To: <20150812103659.GA22571@mwanda>
On 8/12/2015 1:36 PM, Dan Carpenter wrote:
> Hello Sagi Grimberg,
>
> The patch e6631814fb3a: "IB/mlx5: Support IB_WR_REG_SIG_MR" from Feb
> 23, 2014, leads to the following static checker warning:
>
> drivers/infiniband/ulp/ipoib/ipoib_cm.c:764 ipoib_cm_send()
> warn: 'rc' can be either negative or positive
>
> drivers/infiniband/hw/mlx5/qp.c
> 2417 static int set_psv_wr(struct ib_sig_domain *domain,
> 2418 u32 psv_idx, void **seg, int *size)
> 2419 {
> 2420 struct mlx5_seg_set_psv *psv_seg = *seg;
> 2421
> 2422 memset(psv_seg, 0, sizeof(*psv_seg));
> 2423 psv_seg->psv_num = cpu_to_be32(psv_idx);
> 2424 switch (domain->sig_type) {
> 2425 case IB_SIG_TYPE_NONE:
> 2426 break;
> 2427 case IB_SIG_TYPE_T10_DIF:
> 2428 psv_seg->transient_sig = cpu_to_be32(domain->sig.dif.bg << 16 |
> 2429 domain->sig.dif.app_tag);
> 2430 psv_seg->ref_tag = cpu_to_be32(domain->sig.dif.ref_tag);
> 2431 break;
> 2432 default:
> 2433 pr_err("Bad signature type given.\n");
> 2434 return 1;
>
> Probably we should return -EINVAL here? It actually really upsets the
> static checker because all the callers expect negative error codes and
> there are lot of callers.
I'll send out a fix for it.
Thanks Dan.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-08-12 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 10:36 IB/mlx5: Support IB_WR_REG_SIG_MR Dan Carpenter
2015-08-12 17:19 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB8019.5010609@dev.mellanox.co.il \
--to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).