From mboxrd@z Thu Jan  1 00:00:00 1970
From: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 2/3] Add on-demand paging support
Date: Thu, 3 Sep 2015 09:46:35 +0300
Message-ID: <55E7ECCB.209@mellanox.com>
References: <1440688955-7709-1-git-send-email-haggaie@mellanox.com>
 <1440688955-7709-3-git-send-email-haggaie@mellanox.com>
 <55E74B5B.90805@dev.mellanox.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Return-path: <linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
In-Reply-To: <55E74B5B.90805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>, Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Yevgeny Petrilin <yevgenyp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Eran Ben Elisha <eranbe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Moshe Lazer <moshel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Shachar Raindel <raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
List-Id: linux-rdma@vger.kernel.org

On 02/09/2015 22:17, Sagi Grimberg wrote:
> On 8/27/2015 6:22 PM, Haggai Eran wrote:
>> On-demand paging feature allows registering memory regions without
>> pinning
>> their pages. Unfortunately the feature doesn't work together will all
>> transports and all operations. This patch adds the ability to report
>> on-demand
>> paging capabilities through the ibv_query_device_ex.
>>
>> The patch also add the IBV_ACCESS_ON_DEMAND access flag to allow
>> registration
>> of on-demand paging enabled memory regions.
>>
>> Signed-off-by: Shachar Raindel <raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> Signed-off-by: Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> Signed-off-by: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> ---
> 
> Looks good,
> 
> Reviewed-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> I have a patch to add ODP support to TGT user-space target.
> The performance gain is a clear cut.
> 
> Doug, can we get this in?

I received some comments from Moshe Lazer about the first patch in this
series that I should fix. Mainly, the ibv_query_device_ex() verb as it
was defined by the patch doesn't receive an extensible input struct
(only an output struct), and doesn't receive the length of the output
struct.

I'll fix these comments and send a v1.

Haggai

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html