Re: [PATCH v2] xprtrdma: take HCA driver refcount at client

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2063 bytes --]

On 09/03/2015 04:24 PM, Anna Schumaker wrote:
> Hi Doug,
> 
> On 09/03/2015 04:11 PM, Doug Ledford wrote:
>> On 07/30/2015 07:00 AM, Devesh Sharma wrote:
>>> Thanks Chuck Lever for the valuable feedback and suggestions.
>>>
>>> This is a rework of the following patch sent almost a year back:
>>> http://www.mail-archive.com/linux-rdma%40vger.kernel.org/msg20730.html
>>>
>>> In presence of active mount if someone tries to rmmod vendor-driver, the
>>> command remains stuck forever waiting for destruction of all rdma-cm-id.
>>> in worst case client can crash during shutdown with active mounts.
>>>
>>> The existing code assumes that ia->ri_id->device cannot change during
>>> the lifetime of a transport. xprtrdma do not have support for
>>> DEVICE_REMOVAL event either. Lifting that assumption and adding support
>>> for DEVICE_REMOVAL event is a long chain of work, and is in plan.
>>>
>>> The community decided that preventing the hang right now is more
>>> important than waiting for architectural changes.
>>>
>>> Thus, this patch introduces a temporary workaround to acquire HCA driver
>>> module reference count during the mount of a nfs-rdma mount point.
>>>
>>> Cc: chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
>>> Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>> Signed-off-by: Devesh Sharma <devesh.sharma-1wcpHE2jlwO1Z/+hSey0Gg@public.gmane.org>
>>> Reviewed-by: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
>>
>> Chuck, was this given final approval, and if so, who's tree is it
>> expected to go through?  Just trying to make sure I don't need to do
>> anything here as I don't see a rejection in my linux-rdma folder, but I
>> also didn't see it in the initial 4.3 nfs merge.
> 
> This was approved and went through my tree to Trond.  I don't think he's sent out the v4.3 pull request yet, but hopefully it won't be too much longer!

Perfect, thanks!


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]