linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] infiniband:mlx4:Fix assumation that ib_get_cached_pkey runs successfully in build_mlx_header
       [not found] ` <1441839861-4342-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2015-09-10  5:48   ` Or Gerlitz
  0 siblings, 0 replies; only message in thread
From: Or Gerlitz @ 2015-09-10  5:48 UTC (permalink / raw)
  To: Nicholas Krause, dledford-H+wXaHxf7aLQT0dZR+AlfA
  Cc: sean.hefty-ral2JQCrhuEAvxtiuMwx3w,
	hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q,
	jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb,
	roland-BHEL68pLQRGGvPXPguhicg, monis-VPRAkNaXOzVWk0Htik3J/w,
	eranbe-VPRAkNaXOzVWk0Htik3J/w, matanb-VPRAkNaXOzVWk0Htik3J/w,
	yishaih-VPRAkNaXOzVWk0Htik3J/w, eugenia-VPRAkNaXOzVS1MOuV/RT9w,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On 9/10/2015 2:04 AM, Nicholas Krause wrote:
> This fixes a incorrect assumation that ib_get_cached_pkey always runs
> successfully in the function build_mlx_header by checking if the calls
> to this particular function return the error code, -EINVAL in order to
> signal they failed to grap the public key for the device structure pointer
> passed to this function and if so return immediately to the caller of
> mlx_header with the error code -EINVAL to signal a error has occurred
> when calling this particular function that the caller must handle in
> its own intended error paths.

I am totally breathless, put 2-3 periods somewhere along this crazingly 
long sentence.

Does this fixes some specific commit? if yes, please add Fixes: tag @ 
before your S.O.B linewith the offending commit short ID (--abbrev=12)

run speller (e.g assumation  --> assumption), use IB/mlx4: prefix, add 
space between the ":" to the 1st word of the title, e.g:

IB/mlx4: Fix assumption that ib_get_cached_pkey runs successfully in 
build_mlx_header

Or.



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-09-10  5:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1441839861-4342-1-git-send-email-xerofoify@gmail.com>
     [not found] ` <1441839861-4342-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-10  5:48   ` [PATCH] infiniband:mlx4:Fix assumation that ib_get_cached_pkey runs successfully in build_mlx_header Or Gerlitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).