From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH] staging: rdma: Fix braces around if/else Date: Sun, 4 Oct 2015 09:47:52 +0300 Message-ID: <5610CB98.1090907@mellanox.com> References: <1b3a2e933e163bf11a2163c76bedd074551c1b9a.1443901389.git.mkletzan@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1b3a2e933e163bf11a2163c76bedd074551c1b9a.1443901389.git.mkletzan@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Marciniszyn , Doug Ledford , Martin Kletzander , Sean Hefty , Hal Rosenstock List-Id: linux-rdma@vger.kernel.org On 10/3/2015 11:55 PM, Martin Kletzander wrote: > Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. Hi Greg, Is there a way to signal people/tools that a certain driver parks in staging on their way **out** of the kernel and not the other way around? I guess you (nor Doug) don't want to spend time on fixing such drivers, right? Or. > > Signed-off-by: Martin Kletzander > --- > There is one warning reported in this patch though. That's because of > the multiline string and it's pre-existing. Feel free to let me know > if that should be fixed too, I'd also remove the pointless '#' then. > On the other hand, it'll create more-than-80-columns long line. > > drivers/staging/rdma/ipath/ipath_driver.c | 19 ++++++++----------- > drivers/staging/rdma/ipath/ipath_file_ops.c | 12 ++++++------ > drivers/staging/rdma/ipath/ipath_iba6110.c | 7 +++---- > drivers/staging/rdma/ipath/ipath_init_chip.c | 10 +++++----- > drivers/staging/rdma/ipath/ipath_intr.c | 7 +++---- > drivers/staging/rdma/ipath/ipath_sysfs.c | 7 +++---- > drivers/staging/rdma/ipath/ipath_verbs.c | 4 ++-- > 7 files changed, 30 insertions(+), 36 deletions(-)