From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH] IB/core: avoid 32-bit warning Date: Wed, 7 Oct 2015 16:19:27 +0300 Message-ID: <56151BDF.8010504@dev.mellanox.co.il> References: <17269152.DqJfCm1LOx@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <17269152.DqJfCm1LOx@wuerfel> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann , Doug Ledford , Sean Hefty , Hal Rosenstock Cc: Roland Dreier , linux-rdma@vger.kernel.org, Matan Barak , Or Gerlitz , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rdma@vger.kernel.org On 10/7/2015 3:29 PM, Arnd Bergmann wrote: > The INIT_UDATA() macro requires a pointer or unsigned long argument for > both input and output buffer, and all callers had a cast from when > the code was merged until a recent restructuring, so now we get > > core/uverbs_cmd.c: In function 'ib_uverbs_create_cq': > core/uverbs_cmd.c:1481:66: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > This makes the code behave as before by adding back the cast to > unsigned long. > > Signed-off-by: Arnd Bergmann > Fixes: 565197dd8fb1 ("IB/core: Extend ib_uverbs_create_cq") > > diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c > index be4cb9f04be3..88b3b78340f2 100644 > --- a/drivers/infiniband/core/uverbs_cmd.c > +++ b/drivers/infiniband/core/uverbs_cmd.c > @@ -1478,7 +1478,7 @@ ssize_t ib_uverbs_create_cq(struct ib_uverbs_file *file, > if (copy_from_user(&cmd, buf, sizeof(cmd))) > return -EFAULT; > > - INIT_UDATA(&ucore, buf, cmd.response, sizeof(cmd), sizeof(resp)); > + INIT_UDATA(&ucore, buf, (unsigned long)cmd.response, sizeof(cmd), sizeof(resp)); Would it make sense to cast inside INIT_UDATA() and not have callers worry about it?