From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH v2 for-next 1/7] IB/core: Extend ib_uverbs_create_qp Date: Wed, 21 Oct 2015 13:04:38 +0300 Message-ID: <56276336.7000704@mellanox.com> References: <1444909482-17113-1-git-send-email-eranbe@mellanox.com> <1444909482-17113-2-git-send-email-eranbe@mellanox.com> <56276095.6020803@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56276095.6020803-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg , Eran Ben Elisha , Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Lameter List-Id: linux-rdma@vger.kernel.org On 10/21/2015 12:53 PM, Sagi Grimberg wrote: > On 10/15/2015 2:44 PM, Eran Ben Elisha wrote: > > >> +struct ib_uverbs_ex_create_qp { >> + __u64 user_handle; >> + __u32 pd_handle; >> + __u32 send_cq_handle; >> + __u32 recv_cq_handle; >> + __u32 srq_handle; >> + __u32 max_send_wr; >> + __u32 max_recv_wr; >> + __u32 max_send_sge; >> + __u32 max_recv_sge; >> + __u32 max_inline_data; >> + __u8 sq_sig_all; >> + __u8 qp_type; >> + __u8 is_srq; >> + __u8 reserved; >> + __u32 comp_mask; >> + __u32 create_flags; > > Can we please make create_flags u64 to begin with? In the kernel we used 4-5 flags over 10 years, why worry? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html