From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: merge struct ib_device_attr into struct ib_device V2 Date: Wed, 21 Oct 2015 12:21:20 -0500 Message-ID: <5627C990.3010000@opengridcomputing.com> References: <56263CE6.5010005@dev.mellanox.co.il> <56265702.1030209@dev.mellanox.co.il> <20151021063830.GA19027@lst.de> <56273459.6050007@mellanox.com> <20151021065134.GA19210@lst.de> <56273AA1.6060607@mellanox.com> <5627B3BA.7060700@sandisk.com> <20151021164356.GA17666@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151021164356.GA17666-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe , Bart Van Assche Cc: Or Gerlitz , Christoph Hellwig , Or Gerlitz , Sagi Grimberg , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 10/21/2015 11:43 AM, Jason Gunthorpe wrote: > On Wed, Oct 21, 2015 at 08:48:10AM -0700, Bart Van Assche wrote: >> On 10/21/2015 12:11 AM, Or Gerlitz wrote: >>> haven't found any review or ack to your giant patch that touches the >>> whole subsystem (drivers, core and ULPs) expect from Sagi's -- lets >>> hear more opinions. >> Although I have not yet had the time to review the entire patch, removing >> ib_query_device() seems a great idea to me and an idea that I welcome very >> much. The ib_device_attr structure is too large to be allocated on the >> stack. This means that with Christoph's patch it is no longer needed to call >> kmalloc() + ib_query_device() + kfree() when a device attribute is needed >> from kernel code. > I agree, this is absolutely the right way to go. > > The bikeshedding is not important, nobody has come up with a reason > why we need to maintain the attr structure as-is and Christoph already > has a patch - I say go with it. > > Jason > While I don't really like the uber patch review-wise, I'm all for nuking ib_query_device() and the attr struct. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html