linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 28/26] IB/ipath: Remove fast registration from the code
Date: Thu, 29 Oct 2015 11:45:06 -0400	[thread overview]
Message-ID: <56323F02.8040803@redhat.com> (raw)
In-Reply-To: <1446132812-20170-2-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]

On 10/29/2015 11:33 AM, Sagi Grimberg wrote:
> The driver does not support it anyway, and the support
> should be added to a generic layer shared by both hfi1,
> qib and softroce drivers.

Thanks, applied.

> Signed-off-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>  drivers/staging/rdma/ipath/ipath_verbs.c |    3 ---
>  drivers/staging/rdma/ipath/ipath_verbs.h |    1 -
>  2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rdma/ipath/ipath_verbs.c b/drivers/staging/rdma/ipath/ipath_verbs.c
> index 15633ec..29e9179 100644
> --- a/drivers/staging/rdma/ipath/ipath_verbs.c
> +++ b/drivers/staging/rdma/ipath/ipath_verbs.c
> @@ -399,9 +399,6 @@ static int ipath_post_one_send(struct ipath_qp *qp, struct ib_send_wr *wr)
>  	if (qp->ibqp.qp_type != IB_QPT_UC &&
>  	    qp->ibqp.qp_type != IB_QPT_RC)
>  		memcpy(&wqe->ud_wr, ud_wr(wr), sizeof(wqe->ud_wr));
> -	else if (wr->opcode == IB_WR_FAST_REG_MR)
> -		memcpy(&wqe->fast_reg_wr, fast_reg_wr(wr),
> -			sizeof(wqe->fast_reg_wr));
>  	else if (wr->opcode == IB_WR_RDMA_WRITE_WITH_IMM ||
>  		 wr->opcode == IB_WR_RDMA_WRITE ||
>  		 wr->opcode == IB_WR_RDMA_READ)
> diff --git a/drivers/staging/rdma/ipath/ipath_verbs.h b/drivers/staging/rdma/ipath/ipath_verbs.h
> index ed102a2..0a90a56 100644
> --- a/drivers/staging/rdma/ipath/ipath_verbs.h
> +++ b/drivers/staging/rdma/ipath/ipath_verbs.h
> @@ -280,7 +280,6 @@ struct ipath_swqe {
>  	union {
>  		struct ib_send_wr wr;   /* don't use wr.sg_list */
>  		struct ib_ud_wr ud_wr;
> -		struct ib_fast_reg_wr fast_reg_wr;
>  		struct ib_rdma_wr rdma_wr;
>  		struct ib_atomic_wr atomic_wr;
>  	};
> 


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

  parent reply	other threads:[~2015-10-29 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 15:33 [PATCH v5 27/26] IB/hfi1: Remove fast registration from the code Sagi Grimberg
     [not found] ` <1446132812-20170-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-10-29 15:33   ` [PATCH 28/26] IB/ipath: " Sagi Grimberg
     [not found]     ` <1446132812-20170-2-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-10-29 15:45       ` Doug Ledford [this message]
     [not found]         ` <56323F02.8040803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-10-29 15:49           ` Doug Ledford
2015-10-29 15:44   ` [PATCH v5 27/26] IB/hfi1: " Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56323F02.8040803@redhat.com \
    --to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).