Re: [PATCH] IB/core, cma: Make __attribute_const__ declarations sparse-friendly

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

On 10/29/2015 05:16 PM, Bart Van Assche wrote:
> On 08/14/2015 12:27 PM, Doug Ledford wrote:
>> On 08/03/2015 01:01 PM, Bart Van Assche wrote:
>>> Move the __attribute_const__ declarations such that sparse understands
>>> that these apply to the function itself and not to the return type.
>>> This avoids that sparse reports error messages like the following:
>>>
>>> drivers/infiniband/core/verbs.c:73:12: error: symbol 'ib_event_msg'
>>> redeclared with different type (originally declared at
>>> include/rdma/ib_verbs.h:470) - different modifiers
>>>
>>> Fixes: 2b1b5b601230 ("IB/core, cma: Nice log-friendly string helpers")
>>> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
>>> Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> Thanks, applied.
> 
> (replying to an e-mail of two months ago)
> 
> Hi Doug,
> 
> On which branch has this patch been applied ? I couldn't find it in your
> k.o/for-4.4 branch.

I can't find it myself.  Either I said I was taking it and then it got
overlooked, or it got lost sometime during a rebase.  I've added it to
the for-next stack.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]