From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH 4/7] IB/srp: Fix a potential queue overflow in an error path Date: Tue, 3 Nov 2015 19:36:13 +0200 Message-ID: <5638F08D.9070206@dev.mellanox.co.il> References: <562FF404.7000504@sandisk.com> <562FF484.6030400@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <562FF484.6030400-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bart Van Assche , Doug Ledford Cc: Sebastian Parschauer , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 28/10/2015 00:02, Bart Van Assche wrote: > Wait until memory registration has finished in the srp_queuecommand() > error path before invalidating memory regions to avoid a send queue > overflow. This looks backwards to me... Why do we even post anything on our queue-pair to begin with if we got an unsupported sg list? Can't we perform a simple sanity check on the sg list instead? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html