linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Steve Wise
	<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	"Nicholas A. Bellinger"
	<nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>,
	Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v2 0/2] Handle mlx4 max_sge_rd correctly
Date: Tue, 10 Nov 2015 12:36:44 +0200	[thread overview]
Message-ID: <5641C8BC.40507@dev.mellanox.co.il> (raw)
In-Reply-To: <1446031696-19022-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>



On 28/10/2015 13:28, Sagi Grimberg wrote:
> This addresses a specific mlx4 issue where the max_sge_rd
> is actually smaller than max_sge (rdma reads with max_sge
> entries completes with error).
>
> The second patch removes the explicit work-around from the
> iser target code.
>
> Changes from v1:
> - Fixed driver rdma segment size to be 16 bytes
>
> Changes from v0:
> - Used a dedicated enumeration MLX4_MAX_SGE_RD and added
>    a root cause analysis to patch change log.
>
> - Fixed isert qp creation to be max_sge but construct rdma
>    work request with the minimum of max_sge and max_sge_rd
>    as non-rdma sends (login rsp) take 2 sges (and some devices
>    have max_sge_rd = 1.
>
> Sagi Grimberg (2):
>    mlx4: Expose correct max_sge_rd limit
>    iser-target: Remove explicit mlx4 work-around
>
>   drivers/infiniband/hw/mlx4/main.c       |    2 +-
>   drivers/infiniband/ulp/isert/ib_isert.c |   13 +++----------
>   include/linux/mlx4/device.h             |   11 +++++++++++
>   3 files changed, 15 insertions(+), 11 deletions(-)
>

Doug,

Any reply on this patchset?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-11-10 10:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 11:28 [PATCH v2 0/2] Handle mlx4 max_sge_rd correctly Sagi Grimberg
2015-10-28 11:28 ` [PATCH v2 1/2] mlx4: Expose correct max_sge_rd limit Sagi Grimberg
2015-12-08 17:56   ` Doug Ledford
     [not found] ` <1446031696-19022-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-10-28 11:28   ` [PATCH v2 2/2] iser-target: Remove explicit mlx4 work-around Sagi Grimberg
2015-11-10 10:36   ` Sagi Grimberg [this message]
     [not found]     ` <5641C8BC.40507-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-03 14:27       ` [PATCH v2 0/2] Handle mlx4 max_sge_rd correctly Christoph Hellwig
     [not found]         ` <20151203142730.GA20520-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-12-03 15:07           ` Sagi Grimberg
2015-12-08 17:01             ` Christoph Hellwig
     [not found]               ` <20151208170139.GA425-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2015-12-08 17:58                 ` Doug Ledford
2015-12-08 18:13                   ` Sagi Grimberg
2015-12-08 18:17                     ` Doug Ledford
     [not found]                       ` <56671EB8.6010207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-12-08 18:18                         ` Doug Ledford
2015-12-09  9:33                           ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5641C8BC.40507@dev.mellanox.co.il \
    --to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org \
    --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    --cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).