From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH for-next 06/10] iser-target: Remove unused file iser_proto.h Date: Tue, 17 Nov 2015 11:46:01 +0200 Message-ID: <564AF759.1040505@dev.mellanox.co.il> References: <1447691861-3796-1-git-send-email-sagig@mellanox.com> <1447691861-3796-7-git-send-email-sagig@mellanox.com> <20151117090046.GD19578@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151117090046.GD19578-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig , Sagi Grimberg Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Nicholas A. Bellinger" , Or Gerlitz , Steve Wise List-Id: linux-rdma@vger.kernel.org On 17/11/2015 11:00, Christoph Hellwig wrote: > Sorry for the nitpicking, but: > >> +/*Constant PDU lengths calculations */ > > This really needs a space before the 'C'. > >> +#define ISER_HEADERS_LEN (sizeof(struct iser_ctrl) + sizeof(struct iscsi_hdr)) > > Also fixing lines over 8- characters would be nice. It was just a copy-paste kinda thing... I'll fix though. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html