From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 6/9] srp: use the new CQ API Date: Tue, 17 Nov 2015 11:56:39 -0800 Message-ID: <564B8677.8090903@sandisk.com> References: <1447422410-20891-1-git-send-email-hch@lst.de> <1447422410-20891-7-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447422410-20891-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org, bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org, axboe-b10kYP2dOMg@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 11/13/2015 05:46 AM, Christoph Hellwig wrote: > +static void srp_inv_rkey_done(struct ib_cq *cq, struct ib_wc *wc) > +{ > + srp_handle_qp_err(cq, wc, "INV RKEY"); > +} > > [ ... ] > > +static void srp_reg_mr_done(struct ib_cq *cq, struct ib_wc *wc) > +{ > + srp_handle_qp_err(cq, wc, "FAST REG"); > +} How about using names like srp_inv_rkey_err() and srp_reg_mr_err() to make clear that these completion functions are only called if an error occurred ? Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html