From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH 6/6] IB/srp: Fix srp_map_sg_fr() Date: Wed, 2 Dec 2015 14:50:21 +0200 Message-ID: <565EE90D.8060303@dev.mellanox.co.il> References: <565DE3EC.2070002@sandisk.com> <565DE4BA.1040703@sandisk.com> <565DE864.5050407@dev.mellanox.co.il> <565DE977.2070606@sandisk.com> <565EDD2A.6050407@dev.mellanox.co.il> <20151202124154.GF28278@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151202124154.GF28278-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig Cc: Bart Van Assche , Doug Ledford , Sebastian Parschauer , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org > dma_map_sg returns the actual number of entries to iterate. At least > historically some IOMMU implementations would do strange tricks like: > > If entries 2 and 3 could be merged dma_len for 2 would span 2 and 3, > and then entry 3 would actually have the dma addr and len for entry 4. > > I'm not sure anyone still does that, but the first spot to check would > be the Parisc IOMMU drivers. Oh I see, I didn't know that. Thanks for clarifying this for me. AFAICT this patch is fine. Reviewed-by: Sagi Grimberg iser, nfs needs fixing too. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html