From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Erez Shitrit
<erezsh-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] IB/ipoib: Change sendq threshold size
Date: Tue, 15 Dec 2015 12:36:02 -0500 [thread overview]
Message-ID: <56704F82.6060405@redhat.com> (raw)
In-Reply-To: <CAAk-MO_AjkaktRRXEPWSGTqf6t2F_0xS8OFVh_8PN4tyYRMZSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
On 11/17/2015 01:45 AM, Erez Shitrit wrote:
> On Mon, Nov 16, 2015 at 8:54 PM, Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
>> Expecting half of the queue to be empty before reopening netif_queue seems
>> too high.
>> With this fix threshold will be 90%.
>
> Is this backed by tests? why not 75% or 25%?
Much like Erez, I suspect this is a bad change. Unless there are
performance numbers to show that under heavy usage this is actually a
positive change, I'm not inclined to take it.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
next prev parent reply other threads:[~2015-12-15 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 18:54 [PATCH] IB/ipoib: Change sendq threshold size Yuval Shaia
[not found] ` <1447700076-795-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-11-17 6:45 ` Erez Shitrit
[not found] ` <CAAk-MO_AjkaktRRXEPWSGTqf6t2F_0xS8OFVh_8PN4tyYRMZSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-15 17:36 ` Doug Ledford [this message]
2015-11-17 8:11 ` Or Gerlitz
[not found] ` <564AE125.4030700-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-11-17 15:02 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56704F82.6060405@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=erezsh-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).