From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH v3 04/11] xprtrdma: Move struct ib_send_wr off the stack Date: Wed, 16 Dec 2015 16:00:12 +0200 Message-ID: <56716E6C.4020604@dev.mellanox.co.il> References: <20151214211317.16295.70115.stgit@manet.1015granger.net> <20151214211811.16295.47695.stgit@manet.1015granger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151214211811.16295.47695.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chuck Lever , anna.schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org > diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h > index 4197191..e60d817 100644 > --- a/net/sunrpc/xprtrdma/xprt_rdma.h > +++ b/net/sunrpc/xprtrdma/xprt_rdma.h > @@ -206,6 +206,8 @@ struct rpcrdma_frmr { > enum rpcrdma_frmr_state fr_state; > struct work_struct fr_work; > struct rpcrdma_xprt *fr_xprt; > + struct ib_reg_wr fr_regwr; > + struct ib_send_wr fr_invwr; Would it make sense to unionize these as they are guaranteed not to execute together? Some people don't like this sort of savings. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html