From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Eran Ben Elisha <eranbe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>,
Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH for-next V2 5/5] IB/mlx5: Mmap the HCA's core clock register to user-space
Date: Wed, 16 Dec 2015 16:47:03 +0200 [thread overview]
Message-ID: <56717967.8010605@dev.mellanox.co.il> (raw)
In-Reply-To: <1450204213-5630-6-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> enum mlx5_ib_mmap_cmd {
> MLX5_IB_MMAP_REGULAR_PAGE = 0,
> - MLX5_IB_MMAP_GET_CONTIGUOUS_PAGES = 1, /* always last */
> + MLX5_IB_MMAP_GET_CONTIGUOUS_PAGES = 1,
> + /* 5 is chosen in order to be compatible with old versions of libmlx5 */
> + MLX5_IB_MMAP_CORE_CLOCK = 5,
> };
Overall the patches look good so I'd suggest not to apply atop of
the contig pages patchset from Yishai which obviously involves some
debate. Although if this bit is the only conflict then perhaps doug can
take care of it...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-16 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 18:30 [PATCH for-next V2 0/5] User-space time-stamping support for mlx5_ib Matan Barak
[not found] ` <1450204213-5630-1-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-15 18:30 ` [PATCH for-next V2 1/5] IB/mlx5: Add create_cq extended command Matan Barak
2015-12-15 18:30 ` [PATCH for-next V2 2/5] IB/core: Add ib_is_udata_cleared Matan Barak
[not found] ` <1450204213-5630-3-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-16 14:35 ` Haggai Eran
2015-12-15 18:30 ` [PATCH for-next V2 3/5] IB/mlx5: Add support for hca_core_clock and timestamp_mask Matan Barak
[not found] ` <1450204213-5630-4-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-16 14:43 ` Sagi Grimberg
[not found] ` <567178A6.7040700-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-16 14:50 ` Matan Barak
2015-12-15 18:30 ` [PATCH for-next V2 4/5] IB/mlx5: Add hca_core_clock_offset to udata in init_ucontext Matan Barak
[not found] ` <1450204213-5630-5-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-22 21:37 ` Or Gerlitz
[not found] ` <CAJ3xEMguJeQnrHAM9WCXZf+NyNOwBGCfpka5ywUtfLHT1wL3ig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-23 9:03 ` Or Gerlitz
[not found] ` <567A6370.1030008-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-23 9:58 ` Matan Barak
2015-12-15 18:30 ` [PATCH for-next V2 5/5] IB/mlx5: Mmap the HCA's core clock register to user-space Matan Barak
[not found] ` <1450204213-5630-6-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-12-16 14:47 ` Sagi Grimberg [this message]
2015-12-23 17:16 ` [PATCH for-next V2 0/5] User-space time-stamping support for mlx5_ib Or Gerlitz
[not found] ` <CAJ3xEMiJJ0HcxDn_xfPDRK8V1cfN5HNVm9dt6gPaw2iJwD8jhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-24 4:35 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56717967.8010605@dev.mellanox.co.il \
--to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=eranbe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox