Re: [PATCH for-next V2 5/5] IB/mlx5: Mmap the HCA's core clock register to user-space

Sagi Grimberg
2015-12-16T14:47:03Z

> enum mlx5_ib_mmap_cmd {
> MLX5_IB_MMAP_REGULAR_PAGE = 0,
> - MLX5_IB_MMAP_GET_CONTIGUOUS_PAGES = 1, /* always last */
> + MLX5_IB_MMAP_GET_CONTIGUOUS_PAGES = 1,
> + /* 5 is chosen in order to be compatible with old versions of libmlx5 */
> + MLX5_IB_MMAP_CORE_CLOCK = 5,
> };

Overall the patches look good so I'd suggest not to apply atop of
the contig pages patchset from Yishai which obviously involves some
debate. Although if this bit is the only conflict then perhaps doug can
take care of it...