From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH rdma-next 1/6] IB/core: Save the device attributes on the device structure Date: Thu, 17 Dec 2015 15:44:19 +0200 Message-ID: <5672BC33.9050606@dev.mellanox.co.il> References: <1450358340-19361-1-git-send-email-ogerlitz@mellanox.com> <1450358340-19361-2-git-send-email-ogerlitz@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1450358340-19361-2-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz , Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sagi Grimberg , Chuck Lever , Anna Schumaker , santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, Ira Weiny List-Id: linux-rdma@vger.kernel.org > + ret = ib_query_device(device, &device->attrs); > + if (ret) { > + printk(KERN_WARNING "Couldn't query the device attributes\n"); > + goto out; > + } > + I thought we're all for removing the call altogether aren't we? I'd say just call device->query_device() instead. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html