From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH rdma-next 1/6] IB/core: Save the device attributes on the device structure Date: Thu, 17 Dec 2015 19:31:20 +0100 Message-ID: <5672FF78.40401@sandisk.com> References: <1450358340-19361-1-git-send-email-ogerlitz@mellanox.com> <1450358340-19361-2-git-send-email-ogerlitz@mellanox.com> <5672BC33.9050606@dev.mellanox.co.il> <20151217174138.GB26015@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151217174138.GB26015-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe , Sagi Grimberg Cc: Or Gerlitz , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sagi Grimberg , Chuck Lever , Anna Schumaker , santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, Ira Weiny List-Id: linux-rdma@vger.kernel.org On 12/17/2015 06:41 PM, Jason Gunthorpe wrote: > On Thu, Dec 17, 2015 at 03:44:19PM +0200, Sagi Grimberg wrote: >> >>> + ret = ib_query_device(device, &device->attrs); >>> + if (ret) { >>> + printk(KERN_WARNING "Couldn't query the device attributes\n"); >>> + goto out; >>> + } >>> + >> >> I thought we're all for removing the call altogether aren't we? >> >> I'd say just call device->query_device() instead. > > Christoph's patch even got rid of device->query_device(), which, IHMO, > I prefer to see over this. It re-enforces that these values are > constants and drivers cannot change them on the fly. I also would like to see the query_device() implementations to be removed from the hw drivers. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html