From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr Date: Sun, 20 Dec 2015 09:36:57 +0200 Message-ID: <56765A99.3080504@mellanox.com> References: <1450446906-10336-1-git-send-email-hch@lst.de> <1450446906-10336-11-git-send-email-hch@lst.de> <567657D1.5010700@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <567657D1.5010700-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig , Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 12/20/2015 9:25 AM, Or Gerlitz wrote: > On 12/18/2015 3:55 PM, Christoph Hellwig wrote: >> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h >> index 284916d..e45776e 100644 >> --- a/include/rdma/ib_verbs.h >> +++ b/include/rdma/ib_verbs.h >> @@ -1306,7 +1306,6 @@ struct ib_mr { >> u64 iova; >> u32 length; >> unsigned int page_size; >> - atomic_t usecnt; /* count number of MWs */ >> }; > > This comment is part of Roland's uverbs commit. I saw now that you removed in-kernel support for MWs as a downstream patch of this series. I guess this cleanup needs to go there as the refcount field of kernel MRs relates to MWs. This will also help someone coming in the future and returning the in-kernel MW support to avoid forgetting on doing the refs. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html