Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

Or Gerlitz
2015-12-20T07:36:57Z

On 12/20/2015 9:25 AM, Or Gerlitz wrote:
> On 12/18/2015 3:55 PM, Christoph Hellwig wrote:
>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
>> index 284916d..e45776e 100644
>> --- a/include/rdma/ib_verbs.h
>> +++ b/include/rdma/ib_verbs.h
>> @@ -1306,7 +1306,6 @@ struct ib_mr {
>> u64 iova;
>> u32 length;
>> unsigned int page_size;
>> - atomic_t usecnt; /* count number of MWs */
>> };
>
> This comment is part of Roland's uverbs commit.

I saw now that you removed in-kernel support for MWs as a downstream patch
of this series. I guess this cleanup needs to go there as the refcount
field of
kernel MRs relates to MWs. This will also help someone coming in the future
and returning the in-kernel MW support to avoid forgetting on doing the
refs.

Or.