Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2624 bytes --]

On 12/22/2015 02:26 PM, Matan Barak wrote:
> On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>> On 12/22/2015 05:47 AM, Or Gerlitz wrote:
>>> On 12/21/2015 5:01 PM, Matan Barak wrote:
>>>> Previously, cma_match_net_dev called cma_protocol_roce which
>>>> tried to verify that the IB device uses RoCE protocol. However,
>>>> if rdma_id didn't have a bounded port, it used the first port
>>>> of the device.
>>>>
>>>> In VPI systems, the first port might be an IB port while the second
>>>> one could be an Ethernet port. This made requests for unbounded rdma_ids
>>>> that come from the Ethernet port fail.
>>>> Fixing this by passing the port of the request and checking this port
>>>> of the device.
>>>>
>>>> Fixes: b8cab5dab15f ('IB/cma: Accept connection without a valid netdev
>>>> on RoCE')
>>>> Signed-off-by: Matan Barak<matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>>
>>> seems that the patch is missing from patchworks, I can't explain that.
>>
>> I've already downloaded it and marked it accepted.
>>
> 
> Thanks Doug. Would you like that I'll repost the patch with the commit
> message changed as Or suggested or is the current version good enough?

I rewrote most of the commit message myself.  It now reads as such:

commit b00a1609f845df4c75bc62f56d0d71a01fe87cc6
Author: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Date:   Mon Dec 21 17:01:24 2015 +0200

    IB/cma: cma_match_net_dev needs to take into account port_num

    Previously, cma_match_net_dev called cma_protocol_roce which
    tried to verify that the IB device uses RoCE protocol. However,
    if rdma_id wasn't bound to a port, then the check would occur
    against the first port of the device without regard to whether
    that port was even of the same type as the type of port the
    incoming packet was received on.

    Fix this by passing the port of the request and only checking
    against the same port of the device.

    Fixes: b8cab5dab15f ('IB/cma: Accept connection without a valid
netdev on RoCE')
    Signed-off-by: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
    Signed-off-by: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>


> Regarding the Ethernet loopback issue, I started looking into that,
> but as Or stated, it's broken even before the RoCE patches.

Sure, let me know if you root cause it, I'd like to get it into 4.5 if
possible.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]