linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] IB/mlx4: Replace kfree with kvfree in mlx4_ib_destroy_srq
@ 2015-12-17  2:54 Wengang Wang
       [not found] ` <1450320855-4570-1-git-send-email-wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Wengang Wang @ 2015-12-17  2:54 UTC (permalink / raw)
  To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
  Cc: wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA, Matt-goXnUAHYgFxWk0Htik3J/w

Commit 0ef2f05c7e02ff99c0b5b583d7dee2cd12b053f2 uses vmalloc for WR buffers
when needed and uses kvfree to free the buffers. It missed changing kfree
to kvfree in mlx4_ib_destroy_srq().

Reported-by: Matthew Finaly <matt-goXnUAHYgFxWk0Htik3J/w@public.gmane.org>
Signed-off-by: Wengang Wang <wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 drivers/infiniband/hw/mlx4/srq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx4/srq.c b/drivers/infiniband/hw/mlx4/srq.c
index 8d133c4..c394376 100644
--- a/drivers/infiniband/hw/mlx4/srq.c
+++ b/drivers/infiniband/hw/mlx4/srq.c
@@ -286,7 +286,7 @@ int mlx4_ib_destroy_srq(struct ib_srq *srq)
 		mlx4_ib_db_unmap_user(to_mucontext(srq->uobject->context), &msrq->db);
 		ib_umem_release(msrq->umem);
 	} else {
-		kfree(msrq->wrid);
+		kvfree(msrq->wrid);
 		mlx4_buf_free(dev->dev, msrq->msrq.max << msrq->msrq.wqe_shift,
 			      &msrq->buf);
 		mlx4_db_free(dev->dev, &msrq->db);
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] IB/mlx4: Replace kfree with kvfree in mlx4_ib_destroy_srq
       [not found] ` <1450320855-4570-1-git-send-email-wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
@ 2015-12-23 19:35   ` Doug Ledford
  0 siblings, 0 replies; 2+ messages in thread
From: Doug Ledford @ 2015-12-23 19:35 UTC (permalink / raw)
  To: Wengang Wang, linux-rdma-u79uwXL29TY76Z2rM5mHXA
  Cc: Matt-goXnUAHYgFxWk0Htik3J/w

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

On 12/16/2015 09:54 PM, Wengang Wang wrote:
> Commit 0ef2f05c7e02ff99c0b5b583d7dee2cd12b053f2 uses vmalloc for WR buffers
> when needed and uses kvfree to free the buffers. It missed changing kfree
> to kvfree in mlx4_ib_destroy_srq().
> 
> Reported-by: Matthew Finaly <matt-goXnUAHYgFxWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Wengang Wang <wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/infiniband/hw/mlx4/srq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/srq.c b/drivers/infiniband/hw/mlx4/srq.c
> index 8d133c4..c394376 100644
> --- a/drivers/infiniband/hw/mlx4/srq.c
> +++ b/drivers/infiniband/hw/mlx4/srq.c
> @@ -286,7 +286,7 @@ int mlx4_ib_destroy_srq(struct ib_srq *srq)
>  		mlx4_ib_db_unmap_user(to_mucontext(srq->uobject->context), &msrq->db);
>  		ib_umem_release(msrq->umem);
>  	} else {
> -		kfree(msrq->wrid);
> +		kvfree(msrq->wrid);
>  		mlx4_buf_free(dev->dev, msrq->msrq.max << msrq->msrq.wqe_shift,
>  			      &msrq->buf);
>  		mlx4_db_free(dev->dev, &msrq->db);
> 

Thanks, applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-23 19:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-17  2:54 [PATCH] IB/mlx4: Replace kfree with kvfree in mlx4_ib_destroy_srq Wengang Wang
     [not found] ` <1450320855-4570-1-git-send-email-wen.gang.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2015-12-23 19:35   ` Doug Ledford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).