From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH V2] IB/mlx5: Unify CQ create flags check
Date: Tue, 29 Dec 2015 15:51:47 +0200 [thread overview]
Message-ID: <56828FF3.7010904@dev.mellanox.co.il> (raw)
In-Reply-To: <1451388884-11673-1-git-send-email-leon-2ukJVAZIZ/Y@public.gmane.org>
> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> The create_cq() can receive creation flags which were used
> differently by two following commits [1] and [2]. The current
> code caused to not accept any flags at all.
We can skip referencing the linux-rdma mailing list.
>
> This patch unifies the check into one function and one return
> error code.
>
> Fixes: 972ecb821379 ("IB/mlx5: Add create_cq extended command")
> Fixes: 051f263098a9 ("IB/mlx5: Add driver cross-channel support")
>
> [1] http://www.spinics.net/lists/linux-rdma/msg31430.html
> [2] http://www.spinics.net/lists/linux-rdma/msg31658.html
>
> Changes from v0:
> * Add Fixes tag
Umm, the above ([1], [2], Changes) usually go under the "---"
separator so we won't see them in git log forever.
>
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> drivers/infiniband/hw/mlx5/cq.c | 9 +--------
> drivers/infiniband/hw/mlx5/mlx5_ib.h | 3 ++-
> 2 files changed, 3 insertions(+), 9 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-29 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 11:34 [PATCH V2] IB/mlx5: Unify CQ create flags check Leon Romanovsky
[not found] ` <1451388884-11673-1-git-send-email-leon-2ukJVAZIZ/Y@public.gmane.org>
2015-12-29 13:51 ` Sagi Grimberg [this message]
[not found] ` <56828FF3.7010904-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-12-29 14:03 ` Leon Romanovsky
[not found] ` <20151229140341.GE17694-2ukJVAZIZ/Y@public.gmane.org>
2015-12-29 14:42 ` Leon Romanovsky
-- strict thread matches above, loose matches on Subject: below --
2015-12-29 14:41 Leon Romanovsky
[not found] ` <1451400097-17252-1-git-send-email-leon-2ukJVAZIZ/Y@public.gmane.org>
2015-12-29 14:47 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56828FF3.7010904@dev.mellanox.co.il \
--to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-2ukJVAZIZ/Y@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).