From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matan Barak Subject: Re: [PATCH for-next 2/7] IB/mlx4: Add RoCE per GID support for add_gid and del_gid Date: Wed, 30 Dec 2015 12:21:05 +0200 Message-ID: <5683B011.7090207@mellanox.com> References: <1451395447-5198-1-git-send-email-matanb@mellanox.com> <1451395447-5198-3-git-send-email-matanb@mellanox.com> <5682A5AA.9040709@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5682A5AA.9040709-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz , Doug Ledford , Moni Shoua Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yishai Hadas , Majd Dibbiny List-Id: linux-rdma@vger.kernel.org On 12/29/2015 5:24 PM, Or Gerlitz wrote: > On 12/29/2015 3:24 PM, Matan Barak wrote: >> [...] We use a new firmware command in order to populate the GID table >> and store the type along with the GID value. > > Its a new value to existing command.. so better say we use a new value > to the SET_PORT firmware command to do X > Ok > Also here, break out mlx4_core new functionality e.g the changes to > include/linux/mlx4/cmd.h into mlx4_core only patch. You don't need any > change to mlx4_core to have it's own patch, I guess one up to three mlx4 > core patches would be OK. > I'll split mlx4_core logically. > Did you make sure (at the resource tracker) that VFs can't do this new > set port command flavor? > In mlx4_common_set_port: if (slave != dev->caps.function && in_modifier != MLX4_SET_PORT_GENERAL && in_modifier != MLX4_SET_PORT_GID_TABLE) { mlx4_warn(dev, "denying SET_PORT for slave:%d\n", slave); return -EINVAL; } > Also find some spot to put blank line in the change-log, it's hard to > read this way. > No problem > Or. Matan > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html