public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: kamalh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] RXE: A Soft RoCE back-end for the RVT
Date: Thu, 7 Jan 2016 17:44:48 +0200	[thread overview]
Message-ID: <568E87F0.4030506@dev.mellanox.co.il> (raw)
In-Reply-To: <1452106579-4081-1-git-send-email-monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>


> This patch introduces an implementation of a back-end that works with
> RVT to make RoCE Verbs transport over any Ethernet network device.
>
> Example:
>
> After loading ib_rxe_net.ko
> 	echo eth1 > /sys/module/ib_rxe_net/parameters/add
> will create rvt0 IB device in RVT with Ethernet link layer
> ---
>   drivers/infiniband/Kconfig            |    1 +
>   drivers/infiniband/sw/Makefile        |    1 +
>   drivers/infiniband/sw/rxe/Kconfig     |   23 ++
>   drivers/infiniband/sw/rxe/Makefile    |    5 +
>   drivers/infiniband/sw/rxe/rxe_net.c   |  580 +++++++++++++++++++++++++++++++++
>   drivers/infiniband/sw/rxe/rxe_net.h   |   89 +++++
>   drivers/infiniband/sw/rxe/rxe_sysfs.c |  167 ++++++++++
>   7 files changed, 866 insertions(+), 0 deletions(-)

836 LOC SoftRoCE driver, impressive...

> +module_param_call(add, rxe_param_set_add, NULL, NULL, 0200);
> +module_param_call(remove, rxe_param_set_remove, NULL, NULL, 0200);

The standard way of doing this is with class and device structures and
not module_param_call...

You can look at srp for example on how to get it right...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2016-01-07 15:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06 18:56 [PATCH] RXE: A Soft RoCE back-end for the RVT Moni Shoua
     [not found] ` <1452106579-4081-1-git-send-email-monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-01-07  7:08   ` Leon Romanovsky
2016-01-07 15:44   ` Sagi Grimberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568E87F0.4030506@dev.mellanox.co.il \
    --to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=kamalh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox