From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: InfiniBand-ocrdma: Delete unnecessary variable initialisations in 11 functions Date: Fri, 15 Jan 2016 17:24:50 +0100 Message-ID: <56991D52.8030808@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <567EDED5.4040201@users.sourceforge.net> <5697D865.5010507@users.sourceforge.net> <5697DE31.9040309@users.sourceforge.net> <20160115132014.GC30615@leon.nu> <56990733.7000506@users.sourceforge.net> <20160115150935.GA32346@leon.nu> <56990FAC.6000506@users.sourceforge.net> <20160115155938.GB32346@leon.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160115155938.GB32346-2ukJVAZIZ/Y@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky Cc: Devesh Sharma , Doug Ledford , Hal Rosenstock , Mitesh Ahuja , Sean Hefty , Selvin Xavier , LKML , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Julia Lawall List-Id: linux-rdma@vger.kernel.org > GCC supported it before 1999 when I saw it first time. My assumption > that in 2016 all compilers are doing such optimization now. Interesting =85 > I would be glad to hear an example of modern compiler which doesn't > support this simple optimization. Would you like to take into account any other source code analysis appr= oaches? >> Will any configuration parameters and command arguments become relev= ant >> to improve also a corresponding software comparison? >=20 > Please suggest us, you are proposing this change, and not me. Which combination of hardware and software versions would you find repr= esentative for a corresponding system check? >>> The proposed change won't affect performance at all. >> >> Will unneeded variable assignments be really optimised away by defau= lt? >=20 > Yes Can it be that this result will depend on special parameters so that da= ta flow analysis and optimisation will be performed in the way you seem to expe= ct? > If you are interested in saving space of one latter, you need to take= into > account git database increase, do you? There are also other aspects to consider: * Do you insist to initialise a return code at the beginning of every f= unction with a non-void return type? * Does each bit of extra information can result also in unwanted conseq= uences? * Is this a specific source code review concern? * Can this software be improved a bit more only if we dare to talk abou= t potential update candidates? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html