From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
doront-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/IPoIB: Fix kernel panic on multicast flow
Date: Tue, 19 Jan 2016 13:03:24 -0500 [thread overview]
Message-ID: <569E7A6C.5040004@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1601071002220.28791-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On 01/07/2016 11:03 AM, Christoph Lameter wrote:
> On Thu, 7 Jan 2016, Erez Shitrit wrote:
>
>> ipoib_mcast_restart_task calls ipoib_mcast_remove_list with the
>> parameter mcast->dev. That mcast is a temporary (used as an iterator)
>> variable that may be uninitialized.
>> There is no need to send the variable dev to the function, as each mcast
>> has its dev as a member in the mcast struct.
>
> Reviewed-by: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2016-01-19 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 7:28 [PATCH] IB/IPoIB: Fix kernel panic on multicast flow Erez Shitrit
[not found] ` <1452151688-7695-1-git-send-email-erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-01-07 9:23 ` Yuval Shaia
2016-01-07 10:03 ` Erez Shitrit
2016-01-07 16:03 ` Christoph Lameter
[not found] ` <alpine.DEB.2.20.1601071002220.28791-wcBtFHqTun5QOdAKl3ChDw@public.gmane.org>
2016-01-19 18:03 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569E7A6C.5040004@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=doront-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).