From: Doug Ledford <dledford@redhat.com>
To: Christoph Hellwig <hch@lst.de>, Dan Carpenter <dan.carpenter@oracle.com>
Cc: Faisal Latif <faisal.latif@intel.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] RDMA/nes: checking for NULL instead of IS_ERR
Date: Tue, 19 Jan 2016 15:59:48 -0500 [thread overview]
Message-ID: <569EA3C4.5080902@redhat.com> (raw)
In-Reply-To: <20160112151252.GA2294@lst.de>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On 01/12/2016 10:12 AM, Christoph Hellwig wrote:
> On Tue, Jan 12, 2016 at 12:27:43PM +0300, Dan Carpenter wrote:
>> nes_reg_phys_mr() returns ERR_PTRs on error. It doesn't return NULL.
>>
>> This bug has been there for a while, but we recently changed from
>> calling a function pointer to calling nes_reg_phys_mr() directly so now
>> Smatch is able to detect the bug.
>
> Looks fine,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2016-01-19 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 9:27 [patch] RDMA/nes: checking for NULL instead of IS_ERR Dan Carpenter
2016-01-12 15:12 ` Christoph Hellwig
2016-01-19 20:59 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569EA3C4.5080902@redhat.com \
--to=dledford@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=faisal.latif@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).