From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Bart Van Assche
<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] IB/srpt: Remove redundant wc array
Date: Tue, 19 Jan 2016 16:46:33 -0500 [thread overview]
Message-ID: <569EAEB9.2050603@redhat.com> (raw)
In-Reply-To: <1452597590-17850-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]
On 01/12/2016 06:19 AM, Sagi Grimberg wrote:
> No usage after the conversion to the new CQ API.
>
> Signed-off-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> This can go as is or be folded to Christoph's srpt patch,
> whatever works best.
>
> drivers/infiniband/ulp/srpt/ib_srpt.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h b/drivers/infiniband/ulp/srpt/ib_srpt.h
> index ff8b907..247c807 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.h
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.h
> @@ -254,7 +254,6 @@ enum rdma_ch_state {
> * @free_list: Head of list with free send I/O contexts.
> * @state: channel state. See also enum rdma_ch_state.
> * @ioctx_ring: Send ring.
> - * @wc: IB work completion array for srpt_process_completion().
> * @list: Node for insertion in the srpt_device.rch_list list.
> * @cmd_wait_list: List of SCSI commands that arrived before the RTU event. This
> * list contains struct srpt_ioctx elements and is protected
> @@ -281,7 +280,6 @@ struct srpt_rdma_ch {
> struct list_head free_list;
> enum rdma_ch_state state;
> struct srpt_send_ioctx **ioctx_ring;
> - struct ib_wc wc[16];
> struct list_head list;
> struct list_head cmd_wait_list;
> struct se_session *sess;
>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2016-01-19 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 11:19 [PATCH] IB/srpt: Remove redundant wc array Sagi Grimberg
[not found] ` <1452597590-17850-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-01-12 14:33 ` Bart Van Assche
2016-01-12 15:55 ` Christoph Hellwig
2016-01-19 21:46 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569EAEB9.2050603@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).