From: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 03/21] IB/srpt: Remove struct srpt_node_acl
Date: Tue, 9 Feb 2016 07:13:37 -0800 [thread overview]
Message-ID: <56BA0221.3090308@sandisk.com> (raw)
In-Reply-To: <20160209150854.GA27614-jcswGhMUV9g@public.gmane.org>
On 02/09/16 07:08, Christoph Hellwig wrote:
> On Tue, Feb 09, 2016 at 07:03:52AM -0800, Bart Van Assche wrote:
>> On 02/09/16 05:15, Christoph Hellwig wrote:
>>>> - .node_acl_size = sizeof(struct srpt_node_acl),
>>>> + .node_acl_size = sizeof(struct se_node_acl),
>>>
>>> just drop this line entirely, the core code will do the right thing.
>>
>> Hello Christoph,
>>
>> Can you show me the code in the LIO core that handles not specifying
>> .node_acl_size ? I have tried to find it but haven't found it yet.
>
> static struct se_node_acl *target_alloc_node_acl(struct se_portal_group *tpg,
> const unsigned char *initiatorname)
> {
> struct se_node_acl *acl;
> u32 queue_depth;
>
> acl = kzalloc(max(sizeof(*acl), tpg->se_tpg_tfo->node_acl_size),
> GFP_KERNEL);
Hello Christoph,
Ah, thanks, I came across that code but had overlooked the "max()" part
in the above code. I will resubmit this patch series.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-09 15:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 22:44 [PATCH v3 00/21] IB/srpt patches for Linux kernel v4.6 Bart Van Assche
[not found] ` <56B3D453.7030409-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-04 22:45 ` [PATCH v3 01/21] IB/srpt: Simplify srpt_handle_tsk_mgmt() Bart Van Assche
2016-02-04 22:46 ` [PATCH v3 02/21] IB/srpt: Add parentheses around sizeof argument Bart Van Assche
2016-02-04 22:46 ` [PATCH v3 03/21] IB/srpt: Remove struct srpt_node_acl Bart Van Assche
[not found] ` <56B3D4D7.8060800-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-09 13:15 ` Christoph Hellwig
[not found] ` <20160209131507.GA25849-jcswGhMUV9g@public.gmane.org>
2016-02-09 15:03 ` Bart Van Assche
[not found] ` <56B9FFD8.2040809-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-09 15:08 ` Christoph Hellwig
[not found] ` <20160209150854.GA27614-jcswGhMUV9g@public.gmane.org>
2016-02-09 15:13 ` Bart Van Assche [this message]
2016-02-04 22:47 ` [PATCH v3 04/21] IB/srpt: Inline srpt_sdev_name() Bart Van Assche
2016-02-04 22:47 ` [PATCH v3 05/21] IB/srpt: Inline srpt_get_ch_state() Bart Van Assche
2016-02-04 22:48 ` [PATCH v3 06/21] IB/srpt: Introduce target_reverse_dma_direction() Bart Van Assche
2016-02-04 22:48 ` [PATCH v3 07/21] IB/srpt: Use scsilun_to_int() Bart Van Assche
2016-02-04 22:49 ` [PATCH v3 08/21] IB/srpt: Simplify channel state management Bart Van Assche
2016-02-04 22:49 ` [PATCH v3 09/21] IB/srpt: Simplify srpt_shutdown_session() Bart Van Assche
2016-02-04 22:50 ` [PATCH v3 10/21] IB/srpt: Fix srpt_close_session() Bart Van Assche
2016-02-04 22:51 ` [PATCH v3 11/21] IB/srpt: Fix srpt_handle_cmd() error paths Bart Van Assche
2016-02-04 22:52 ` [PATCH v3 12/21] IB/srpt: Fix how aborted commands are processed Bart Van Assche
2016-02-04 22:55 ` [PATCH v3 13/21] IB/srpt: Inline trivial CM callback functions Bart Van Assche
2016-02-04 22:56 ` [PATCH v3 14/21] IB/srpt: Eliminate srpt_find_channel() Bart Van Assche
2016-02-04 22:57 ` [PATCH v3 15/21] IB/srpt: Log private data associated with REJ Bart Van Assche
2016-02-04 22:57 ` [PATCH v3 16/21] IB/srpt: Use a mutex to protect the channel list Bart Van Assche
[not found] ` <56B3D75B.3030202-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-09 13:16 ` Christoph Hellwig
2016-02-04 22:57 ` [PATCH v3 17/21] IB/srpt: Detect session shutdown reliably Bart Van Assche
2016-02-04 22:58 ` [PATCH v3 18/21] IB/srpt: Fix srpt_write_pending() Bart Van Assche
2016-02-04 22:58 ` [PATCH v3 19/21] IB/srpt: Log out all initiators if a port is disabled Bart Van Assche
2016-02-04 22:59 ` [PATCH v3 20/21] IB/srpt: Introduce srpt_process_wait_list() Bart Van Assche
2016-02-04 22:59 ` [PATCH v3 21/21] IB/srpt: Fix wait list processing Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BA0221.3090308@sandisk.com \
--to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
--cc=alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).