Re: [PATCH 0/3] IB/mlx4: Fix extended counters support

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]

On 02/11/2016 03:24 AM, Matan Barak wrote:
> From: Eran Ben Elisha <eranbe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> Hi Doug,
> 
> This series fixes an issue introduced in 4.5 after applying Christoph Lameter's
> "IB 64 bit counter support" series.  Christoph used a mad in order to query the
> vendor driver for extended counters support, however this mad wasn't handled in
> mlx4 when link layer is Ethernet.  Thus, extended counters support was broken.
> In addition, this series fixes a bug in IB/core sysfs which was also introduced
> in "IB 64 bit counter support" series.
> 
> Patch 0001 fixes wrong handling of port info capability mask, which caused
> setting of extended counters sysfs even if underlying device doesn't support
> it.
> Patch 0002-0003 align mlx4 counters sysfs for extended counters scheme in case
> link layer is Ethernet.
> 
> Thanks,
> Eran and Matan.
> 
> Eran Ben Elisha (3):
>   IB/core: Fix reading capability mask of the port info class
>   IB/mlx4: Add support for extended counters over RoCE ports
>   IB/mlx4: Add support for the port info class for RoCE ports
> 
>  drivers/infiniband/core/sysfs.c  |  5 ++--
>  drivers/infiniband/hw/mlx4/mad.c | 63 +++++++++++++++++++++++++++++++---------
>  2 files changed, 52 insertions(+), 16 deletions(-)
> 

Hi Matan,

The first patch is a true bug fix while the next two add the feature to
RoCE mode.  Based upon the code patches, the RoCE code should work fine
for 4.5 without the new support, there isn't a bug there (they simply
won't respond to the ext counters port request).  So I took the first
patch for-rc and the next two I'll put in for-next.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]