linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: [PATCH v4 13/21] IB/srpt: Inline trivial CM callback functions
Date: Thu, 11 Feb 2016 11:07:29 -0800	[thread overview]
Message-ID: <56BCDBF1.8060704@sandisk.com> (raw)
In-Reply-To: <56BCDAAD.7030906-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>

Inline those CM callback functions that are only two lines long.

Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Reviewed-by: Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/ulp/srpt/ib_srpt.c | 37 ++++++++++-------------------------
 1 file changed, 10 insertions(+), 27 deletions(-)

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 64e9107..ea73594 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -2320,18 +2320,6 @@ static void srpt_cm_rtu_recv(struct ib_cm_id *cm_id)
 	}
 }
 
-static void srpt_cm_timewait_exit(struct ib_cm_id *cm_id)
-{
-	pr_info("Received IB TimeWait exit for cm_id %p.\n", cm_id);
-	srpt_drain_channel(cm_id);
-}
-
-static void srpt_cm_rep_error(struct ib_cm_id *cm_id)
-{
-	pr_info("Received IB REP error for cm_id %p.\n", cm_id);
-	srpt_drain_channel(cm_id);
-}
-
 /**
  * srpt_cm_dreq_recv() - Process reception of a DREQ message.
  */
@@ -2370,15 +2358,6 @@ static void srpt_cm_dreq_recv(struct ib_cm_id *cm_id)
 }
 
 /**
- * srpt_cm_drep_recv() - Process reception of a DREP message.
- */
-static void srpt_cm_drep_recv(struct ib_cm_id *cm_id)
-{
-	pr_info("Received InfiniBand DREP message for cm_id %p.\n", cm_id);
-	srpt_drain_channel(cm_id);
-}
-
-/**
  * srpt_cm_handler() - IB connection manager callback function.
  *
  * A non-zero return value will cause the caller destroy the CM ID.
@@ -2409,22 +2388,26 @@ static int srpt_cm_handler(struct ib_cm_id *cm_id, struct ib_cm_event *event)
 		srpt_cm_dreq_recv(cm_id);
 		break;
 	case IB_CM_DREP_RECEIVED:
-		srpt_cm_drep_recv(cm_id);
+		pr_info("Received CM DREP message for cm_id %p.\n",
+			cm_id);
+		srpt_drain_channel(cm_id);
 		break;
 	case IB_CM_TIMEWAIT_EXIT:
-		srpt_cm_timewait_exit(cm_id);
+		pr_info("Received CM TimeWait exit for cm_id %p.\n", cm_id);
+		srpt_drain_channel(cm_id);
 		break;
 	case IB_CM_REP_ERROR:
-		srpt_cm_rep_error(cm_id);
+		pr_info("Received CM REP error for cm_id %p.\n", cm_id);
+		srpt_drain_channel(cm_id);
 		break;
 	case IB_CM_DREQ_ERROR:
-		pr_info("Received IB DREQ ERROR event.\n");
+		pr_info("Received CM DREQ ERROR event.\n");
 		break;
 	case IB_CM_MRA_RECEIVED:
-		pr_info("Received IB MRA event\n");
+		pr_info("Received CM MRA event\n");
 		break;
 	default:
-		pr_err("received unrecognized IB CM event %d\n", event->event);
+		pr_err("received unrecognized CM event %d\n", event->event);
 		break;
 	}
 
-- 
2.7.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-02-11 19:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-11 19:02 [PATCH v4 00/21] IB/srpt patches for Linux kernel v4.6 Bart Van Assche
     [not found] ` <56BCDAAD.7030906-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-11 19:03   ` [PATCH v4 01/21] IB/srpt: Simplify srpt_handle_tsk_mgmt() Bart Van Assche
2016-02-11 19:03   ` [PATCH v4 02/21] IB/srpt: Add parentheses around sizeof argument Bart Van Assche
2016-02-11 19:04   ` [PATCH v4 03/21] IB/srpt: Remove struct srpt_node_acl Bart Van Assche
2016-02-11 19:04   ` [PATCH v4 04/21] IB/srpt: Inline srpt_sdev_name() Bart Van Assche
2016-02-11 19:04   ` [PATCH v4 05/21] IB/srpt: Inline srpt_get_ch_state() Bart Van Assche
2016-02-11 19:05   ` [PATCH v4 06/21] IB/srpt: Introduce target_reverse_dma_direction() Bart Van Assche
2016-02-11 19:05   ` [PATCH v4 07/21] IB/srpt: Use scsilun_to_int() Bart Van Assche
2016-02-11 19:05   ` [PATCH v4 08/21] IB/srpt: Simplify channel state management Bart Van Assche
2016-02-11 19:05   ` [PATCH v4 09/21] IB/srpt: Simplify srpt_shutdown_session() Bart Van Assche
2016-02-11 19:06   ` [PATCH v4 10/21] IB/srpt: Fix srpt_close_session() Bart Van Assche
2016-02-11 19:06   ` [PATCH v4 11/21] IB/srpt: Fix srpt_handle_cmd() error paths Bart Van Assche
2016-02-11 19:07   ` [PATCH v4 12/21] IB/srpt: Fix how aborted commands are processed Bart Van Assche
2016-02-11 19:07   ` Bart Van Assche [this message]
2016-02-11 19:07   ` [PATCH v4 14/21] IB/srpt: Eliminate srpt_find_channel() Bart Van Assche
2016-02-11 19:08   ` [PATCH v4 15/21] IB/srpt: Log private data associated with REJ Bart Van Assche
     [not found]     ` <56BCDC1C.107-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-17 15:57       ` Doug Ledford
     [not found]         ` <56C49854.6010204-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-02-17 23:24           ` Bart Van Assche
     [not found]             ` <56C50110.7060003-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-18 15:14               ` Doug Ledford
2016-02-11 19:08   ` [PATCH v4 16/21] IB/srpt: Use a mutex to protect the channel list Bart Van Assche
2016-02-11 19:08   ` [PATCH v4 17/21] IB/srpt: Detect session shutdown reliably Bart Van Assche
2016-02-11 19:09   ` [PATCH v4 18/21] IB/srpt: Fix srpt_write_pending() Bart Van Assche
2016-02-11 19:09   ` [PATCH v4 19/21] IB/srpt: Log out all initiators if a port is disabled Bart Van Assche
2016-02-11 19:09   ` [PATCH v4 20/21] IB/srpt: Introduce srpt_process_wait_list() Bart Van Assche
2016-02-11 19:10   ` [PATCH v4 21/21] IB/srpt: Fix wait list processing Bart Van Assche
2016-02-17 16:18   ` [PATCH v4 00/21] IB/srpt patches for Linux kernel v4.6 Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BCDBF1.8060704@sandisk.com \
    --to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
    --cc=alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).