Re: [PATCH v5 1/1] IB/ipoib: fix for rare multicast join race condition

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]

On 02/12/2016 04:47 PM, Or Gerlitz wrote:
> On Fri, Feb 12, 2016 at 10:45 PM, Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On Thu, Feb 11, 2016 at 10:30 PM, Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
>>> Proposed patch should prevent multicast join task to continue
>>> if link state change is detected.
>>>
>>> Signed-off-by: Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>>
>>> Changes from v4:
>>> - as suggested by Doug Ledford, optimized spinlock usage,
>>> i.e. ipoib_mcast_join() is called with lock held.
>>> Changes from v3:
>>> - sync with priv->lock before flag check.
>>> Chages from v2:
>>> - Move check for OPER_UP flag state to mcast_join() to
>>> ensure no event worker is in progress.
>>> - minor style fixes.
>>> Changes from v1:
>>> - No need to lock again if error detected.
>>> ---
>>>  drivers/infiniband/ulp/ipoib/ipoib_multicast.c |   24
>>> +++++++++++++++++-------
>>>  1 files changed, 17 insertions(+), 7 deletions(-)
>>>
>>
>>
> 
> Alex, for next times... please put the Vx --> Vy history either in the cover
> letter or in a case where this is single patch (as was here) after the ---
> line, else we'll have this listing present in the upstream kernel git for
> the rest of the human/linux history, since when the maintainer uses git am,
> it goes in.
>>
> Doug, I see now in your github that this indeed went in, could you made a
> small git rebase rewording and remove this review history?
> 

It's not an important enough issue to warrant rebasing a tree that's
already hit my k.o repo where I don't rebase except under dire need.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]