[PATCH] IB/core: Fix missed clean call in registration path

[PATCH] IB/core: Fix missed clean call in registration path

[Leon Romanovsky]

In case of failure returned from query function in
IB device registration, we need to clean IB cache which
was missed.

This change fixes it.

Fixes: 3e153a93a1c1 ('IB/core: Save the device attributes on the device
structure')
Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/core/device.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 00da80e..94b80a5 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -358,6 +358,7 @@ int ib_register_device(struct ib_device *device,
 	ret = device->query_device(device, &device->attrs, &uhw);
 	if (ret) {
 		printk(KERN_WARNING "Couldn't query the device attributes\n");
+		ib_cache_cleanup_one(device);
 		goto out;
 	}
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/core: Fix missed clean call in registration path

[ira.weiny]

On Sun, Feb 21, 2016 at 06:12:26PM +0200, Leon Romanovsky wrote:
> In case of failure returned from query function in
> IB device registration, we need to clean IB cache which
> was missed.
> 
> This change fixes it.
> 
> Fixes: 3e153a93a1c1 ('IB/core: Save the device attributes on the device
> structure')
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

> ---
>  drivers/infiniband/core/device.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 00da80e..94b80a5 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -358,6 +358,7 @@ int ib_register_device(struct ib_device *device,
>  	ret = device->query_device(device, &device->attrs, &uhw);
>  	if (ret) {
>  		printk(KERN_WARNING "Couldn't query the device attributes\n");
> +		ib_cache_cleanup_one(device);
>  		goto out;
>  	}
>  
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/core: Fix missed clean call in registration path

[Sagi Grimberg]

Looks fine,

Reviewed-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/core: Fix missed clean call in registration path

[Leon Romanovsky]

On Sun, Feb 21, 2016 at 08:13:36PM -0500, ira.weiny wrote:
> On Sun, Feb 21, 2016 at 06:12:26PM +0200, Leon Romanovsky wrote:
> > In case of failure returned from query function in
> > IB device registration, we need to clean IB cache which
> > was missed.
> > 
> > This change fixes it.
> > 
> > Fixes: 3e153a93a1c1 ('IB/core: Save the device attributes on the device
> > structure')
> > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 

Thanks Ira and Sagi,
Do you see the need to push this fix to -stable too?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/core: Fix missed clean call in registration path

[Or Gerlitz]

On Mon, Feb 22, 2016 at 10:53 AM, Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org> wrote:
> On Sun, Feb 21, 2016 at 08:13:36PM -0500, ira.weiny wrote:
>> On Sun, Feb 21, 2016 at 06:12:26PM +0200, Leon Romanovsky wrote:
>> > In case of failure returned from query function in
>> > IB device registration, we need to clean IB cache which
>> > was missed.
>> >
>> > This change fixes it.
>> >
>> > Fixes: 3e153a93a1c1 ('IB/core: Save the device attributes on the device
>> > structure')
>> > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>> Reviewed-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>
> Thanks Ira and Sagi,
> Do you see the need to push this fix to -stable too?

$ git tag --contains 3e153a93a1c1
v4.5-rc1
v4.5-rc2
v4.5-rc3
v4.5-rc4
v4.5-rc5
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/core: Fix missed clean call in registration path

[Leon Romanovsky]

On Mon, Feb 22, 2016 at 11:12:46AM +0200, Or Gerlitz wrote:
> On Mon, Feb 22, 2016 at 10:53 AM, Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org> wrote:
> > On Sun, Feb 21, 2016 at 08:13:36PM -0500, ira.weiny wrote:
> >> On Sun, Feb 21, 2016 at 06:12:26PM +0200, Leon Romanovsky wrote:
> >> > In case of failure returned from query function in
> >> > IB device registration, we need to clean IB cache which
> >> > was missed.
> >> >
> >> > This change fixes it.
> >> >
> >> > Fixes: 3e153a93a1c1 ('IB/core: Save the device attributes on the device
> >> > structure')
> >> > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >>
> >> Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >> Reviewed-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >>
> >
> > Thanks Ira and Sagi,
> > Do you see the need to push this fix to -stable too?
> 
> $ git tag --contains 3e153a93a1c1
> v4.5-rc1
> v4.5-rc2
> v4.5-rc3
> v4.5-rc4
> v4.5-rc5

Thanks a lot for pointing it out to me.
You are great
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/core: Fix missed clean call in registration path

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

On 02/22/2016 03:31 AM, Sagi Grimberg wrote:
> Looks fine,
> 
> Reviewed-by: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

This was picked up for late 4.5-rc

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]