From: Sagi Grimberg <sagig@dev.mellanox.co.il>
To: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagig@mellanox.com>
Cc: Max Gurtovoy <maxg@mellanox.com>,
linux-rdma@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 5/5] IB/isert: Kill the ->isert_cmd back pointer in struct iser_tx_desc
Date: Tue, 23 Feb 2016 13:23:58 +0200 [thread overview]
Message-ID: <56CC414E.9020109@dev.mellanox.co.il> (raw)
In-Reply-To: <1456148958-27973-6-git-send-email-hch@lst.de>
> We only use the pointer when processing regular iSER commands, and it then
> always points to the struct iser_cmd that contains the TX descriptor.
That was I hack I knew we will be able to get rid of once we move to
the new CQ API. The iscsi login response is not allocate a command
structure and this back-pointer was used to differentiate that. Now
that the login response has it's own done handler we can get rid of
it.
Thanks!
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
next prev parent reply other threads:[~2016-02-23 11:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 13:49 isert: convert to the new CQ API and a few random cleanups V2 Christoph Hellwig
2016-02-22 13:49 ` [PATCH 2/5] IB/isert: Split and properly type the login buffer Christoph Hellwig
[not found] ` <1456148958-27973-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-23 11:08 ` Sagi Grimberg
2016-02-25 15:19 ` Max Gurtovoy
2016-02-22 13:49 ` [PATCH 4/5] IB/isert: Kill struct isert_rdma_wr Christoph Hellwig
2016-02-23 11:17 ` Sagi Grimberg
[not found] ` <1456148958-27973-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-22 13:49 ` [PATCH 1/5] IB/isert: Remove ISER_RECV_DATA_SEG_LEN Christoph Hellwig
2016-02-22 14:55 ` Or Gerlitz
[not found] ` <CAJ3xEMiGhnsZMdPkqCo25cjdOE8pqZ3A=TfiEvMHsU8Sj3PM8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-22 14:57 ` Or Gerlitz
2016-02-22 15:05 ` Christoph Hellwig
[not found] ` <20160222150558.GA29553-jcswGhMUV9g@public.gmane.org>
2016-02-22 15:41 ` Sagi Grimberg
[not found] ` <1456148958-27973-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-23 11:03 ` Sagi Grimberg
[not found] ` <56CC3C95.7090301-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-25 14:37 ` Max Gurtovoy
2016-02-22 13:49 ` [PATCH 3/5] IB/isert: Convert to new CQ API Christoph Hellwig
2016-02-23 11:15 ` Sagi Grimberg
[not found] ` <56CC3F39.1030002-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-23 13:31 ` Christoph Hellwig
[not found] ` <1456148958-27973-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-24 16:01 ` Sagi Grimberg
2016-02-24 18:43 ` Christoph Hellwig
2016-02-25 16:41 ` Max Gurtovoy
2016-02-22 13:49 ` [PATCH 5/5] IB/isert: Kill the ->isert_cmd back pointer in struct iser_tx_desc Christoph Hellwig
2016-02-23 11:23 ` Sagi Grimberg [this message]
2016-02-23 11:29 ` isert: convert to the new CQ API and a few random cleanups V2 Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC414E.9020109@dev.mellanox.co.il \
--to=sagig@dev.mellanox.co.il \
--cc=hch@lst.de \
--cc=linux-rdma@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox